[Builds] ziptie build.3975 Build Successful

[Leo Bayer]

Oh, never mind, I missed-typed. It should be protocolNumber not name.

  - Leo

On Jun 24, 2008, at 5:29 PM, Leo Bayer wrote:

> Blame Ed, he told me to make the change.  I didn't really think  
> about what it was doing.
>
>  - Leo
>
> On Jun 24, 2008, at 5:25 PM, Brett Wooldridge wrote:
>
>> What does that change actually do?  The code looks like:
>>
>> 175:               if (protocolName != null)
>> 176 :              {
>> 177 :                 if (protocolName == null)
>> 178 :                 {
>> 179 :                    logger.warn("ZipTie-core ...”);
>> 180 :                 }
>> 181 :                 nameToNumberMap.put(protocolName,  
>> protocolNumber);
>> 182 :                 numberToNameMap.put(protocolNumber,  
>> protocolName);
>> 183 :                 protocolList.add(new Protocol(protocolNumber,  
>> protocolName));
>> 184 :                 }
>> 185 :              }
>>
>> It seems like it can never meet the warning condition. If  
>> protocolName is null, it will never get inside the first ‘if’.
>>
>> -Brett
>>
>>
>> On 6/25/08 4:17 AM, "BuildAgent at ziptie.org" <BuildAgent at ziptie.org>  
>> wrote:
>>
>> Ziptie Commits:
>> Date: 06/24/2008 14:11:36
>>
>>  User File Comment
>>  lbayer
>>
>>  IANAProtocolNumbers.java v1.2 <http://ziptie.org/cgi-bin/viewvc.cgi/org.ziptie.adapters/src/org/ziptie/adapters/IANAProtocolNumbers.java?revision=1.2&view=markup 
>> >  only warn if protocolNumber is null
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.ziptie.org/pipermail/builds/attachments/20080624/450119a8/attachment.html